Skip to content

[FBcode->GH] torchvision decoder. fix artifacts, blury images for frame dimensions not multiple of 8 (#7523) #7552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasHug merged 3 commits into from
May 3, 2023
Merged

[FBcode->GH] torchvision decoder. fix artifacts, blury images for frame dimensions not multiple of 8 (#7523) #7552

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdde21c
torchvision decoder. fix artifacts, blury images for frame dimensions…
Apr 17, 2023
de637e5
Format
NicolasHug May 3, 2023
0f68584
Merge branch 'main' into cherry_fbsync
NicolasHug May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions torchvision/csrc/io/decoder/video_sampler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,23 @@ bool VideoSampler::init(const SamplerParameters& params) {
// set output format
params_ = params;

if (params.in.video.format == AV_PIX_FMT_YUV420P) {
/* When the video width and height are not multiples of 8,
* and there is no size change in the conversion,
* a blurry screen will appear on the right side
* This problem was discovered in 2012 and
* continues to exist in version 4.1.3 in 2019
* This problem can be avoided by increasing SWS_ACCURATE_RND
* details https://trac.ffmpeg.org/ticket/1582
*/
if ((params.in.video.width & 0x7) || (params.in.video.height & 0x7)) {
VLOG(1) << "The width " << params.in.video.width << " and height "
<< params.in.video.height << " the image is not a multiple of 8, "
<< "the decoding speed may be reduced";
swsFlags_ |= SWS_ACCURATE_RND;
}
}

scaleContext_ = sws_getContext(
params.in.video.width,
params.in.video.height,
Expand Down