torchvision decoder. fix artifacts, blury images for frame dimensions not multiple of 8 #7523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45035410 |
… not multiple of 8 (pytorch#7523) Summary: Pull Request resolved: pytorch#7523 In MUI we found an artifact for video with resolution 426x426, not equal to 8. We find that root cause is torchvision decoder, which MUI uses extensively Tiny black bar on the right in the image Before the fix {F949912112} After the fix {F949913076} Full video https://pxl.cl/2CN1G https://pxl.cl/2CN1L Differential Revision: D45035410 fbshipit-source-id: ac18424bf7433e046f2c0d7db41cf0b34f931a53
NicolasHug
force-pushed
the
export-D45035410-to-fbsync
branch
from
75af8b5 to
26fa5bd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45035410 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
… not multiple of 8 (#7523) Summary: Pull Request resolved: #7523 In MUI we found an artifact for video with resolution 426x426, not equal to 8. We find that root cause is torchvision decoder, which MUI uses extensively Tiny black bar on the right in the image Before the fix {F949912112} After the fix {F949913076} Full video https://pxl.cl/2CN1G https://pxl.cl/2CN1L Differential Revision: D45035410 fbshipit-source-id: 2d4f6a4812df075fc4677e6b96dc2e0029ea6e92
NicolasHug
pushed a commit
to NicolasHug/vision
that referenced
this pull request
May 2, 2023
… not multiple of 8 (pytorch#7523) Summary: Pull Request resolved: pytorch#7523 In MUI we found an artifact for video with resolution 426x426, not equal to 8. We find that root cause is torchvision decoder, which MUI uses extensively Tiny black bar on the right in the image Before the fix {F949912112} After the fix {F949913076} Full video https://pxl.cl/2CN1G https://pxl.cl/2CN1L Differential Revision: D45035410 fbshipit-source-id: 2d4f6a4812df075fc4677e6b96dc2e0029ea6e92
NicolasHug
added a commit
that referenced
this pull request
May 3, 2023
…me dimensions not multiple of 8 (#7523) (#7552) Co-authored-by: Vadim Zubov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In MUI we found an artifact for video with resolution 426x426, not equal to 8.
We find that root cause is torchvision decoder, which MUI uses extensively
Tiny black bar on the right in the image
Before the fix
{F949912112}
After the fix
{F949913076}
Full video
https://pxl.cl/2CN1G
https://pxl.cl/2CN1L
Differential Revision: D45035410