add macOS unittest to GHA #7376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Mar 3, 2023
Comment on lines
+301
to
+302
| print(f" libpng include path: {jpeg_include}") | ||
| print(f" libpng lib path: {jpeg_lib}") |
Contributor
Author
There was a problem hiding this comment.
Small drive-by that helped me debug. We do the same for PNG already:
Lines 278 to 279 in 0e62c34
I wasn't able to get the version of the library in a way that would hold for all operating systems. I guess knowing the location is good enough.
Comment on lines
+24
to
+32
| # The x86 macOS runners, e.g. the GitHub Actions native "macos-12" runner, has some JPEG libraries installed by default | ||
| # that interfere with our build. We uninstall them here and use the one from conda below. | ||
| if [[ "${OS_TYPE}" == "macos" && $(uname -m) == x86_64 ]]; then | ||
| JPEG_LIBS=$(brew list | grep jpeg) | ||
| echo $JPEG_LIBS | ||
| for lib in $JPEG_LIBS; do | ||
| brew uninstall --ignore-dependencies --force $lib || true | ||
| done | ||
| fi |
Contributor
Author
There was a problem hiding this comment.
We are doing the same for the macOS wheel workflows:
vision/packaging/pre_build_script.sh
Lines 3 to 9 in 0e62c34
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
21 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Reviewed By: vmoens Differential Revision: D44416613 fbshipit-source-id: 5a1ff6c8d7636e77a081809eaf1c848ca4c06a3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
cc @seemethere