-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Promote prototype transforms to beta status #7261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
36ae12e
Copy paste prototype.datapoints and prototype.transforms out of proto…
NicolasHug a144417
make test/test_prototype_transforms_consistency.py use torchvision area
NicolasHug 46086b8
Migrate more tests
NicolasHug 73d0e0f
Updated imports
vfdev-5 1958bcd
Merge branch 'migration_transforms_v2' of github.com:pytorch/vision i…
NicolasHug 6fd6614
Update geometry files
NicolasHug fd751c6
SNEAKY
NicolasHug 2a41357
Some updates, might have broken more stuff
NicolasHug 22c7499
Missed some
NicolasHug 55b3772
Fixed functional tests
vfdev-5 ad87f5b
some removals
NicolasHug ced6992
Fixed issue with temporal test, test_batched_vs_single
vfdev-5 b5a67ab
Merge branch 'migration_transforms_v2' of github.com:pytorch/vision i…
NicolasHug 8511b6f
All test_prototype_transforms* should be passing now
NicolasHug 481b939
Merge branch 'main' into migration_transforms_v2
pmeier f49beb3
cherry-pick d010e82fec10422f79c69564de7ff2721d93d278
pmeier d8ec4f1
migrate video utility transforms back to prototype
pmeier 99590c0
migrate FixedSizeCrop back to prototype
pmeier 8f49358
remove all mentions of Label and OneHotLabel from transforms.v2
pmeier ec805da
Fixed code formatting and failing tests
vfdev-5 86537d7
fix tests
pmeier 3691c8d
Merge branch 'migration_transforms_v2' of https://github.com/pytorch/…
pmeier 1f86853
remove dead code from prototype
pmeier fe00914
lint and prototype datasets
pmeier 64ecaf1
fix dataset wrapper tests
pmeier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmeier what's broken here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing the
LabelandOneHotLabelclasses,RandomIoUCropno longer removes labels since it doesn't have a notion of them. To resolve this, we need to follow my suggestion in the comment and use a composed transform withRandomIoUCropand the newSanitizeBoundingBoxesthat @NicolasHug implemented.