Skip to content

DataPoint.to_grayscale() -> DataPoint.rgb_to_grayscale #7136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasHug merged 2 commits into from
Jan 27, 2023
Merged

DataPoint.to_grayscale() -> DataPoint.rgb_to_grayscale #7136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e74e71
DataPoint.to_grayscale() -> DataPoint.rgb_to_grayscale
NicolasHug Jan 26, 2023
23891d0
Merge branch 'main' into rgb_to_grayscale_rename
NicolasHug Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchvision/prototype/datapoints/_datapoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def elastic(
) -> Datapoint:
return self

def to_grayscale(self, num_output_channels: int = 1) -> Datapoint:
def rgb_to_grayscale(self, num_output_channels: int = 1) -> Datapoint:
return self

def adjust_brightness(self, brightness_factor: float) -> Datapoint:
Expand Down
2 changes: 1 addition & 1 deletion torchvision/prototype/datapoints/_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def elastic(
)
return Image.wrap_like(self, output)

def to_grayscale(self, num_output_channels: int = 1) -> Image:
def rgb_to_grayscale(self, num_output_channels: int = 1) -> Image:
output = self._F.rgb_to_grayscale_image_tensor(
self.as_subclass(torch.Tensor), num_output_channels=num_output_channels
)
Expand Down
2 changes: 1 addition & 1 deletion torchvision/prototype/datapoints/_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def elastic(
)
return Video.wrap_like(self, output)

def to_grayscale(self, num_output_channels: int = 1) -> Video:
def rgb_to_grayscale(self, num_output_channels: int = 1) -> Video:
output = self._F.rgb_to_grayscale_image_tensor(
self.as_subclass(torch.Tensor), num_output_channels=num_output_channels
)
Expand Down
2 changes: 1 addition & 1 deletion torchvision/prototype/transforms/functional/_color.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def rgb_to_grayscale(
if torch.jit.is_scripting() or is_simple_tensor(inpt):
return rgb_to_grayscale_image_tensor(inpt, num_output_channels=num_output_channels)
elif isinstance(inpt, datapoints._datapoint.Datapoint):
return inpt.to_grayscale(num_output_channels=num_output_channels)
return inpt.rgb_to_grayscale(num_output_channels=num_output_channels)
elif isinstance(inpt, PIL.Image.Image):
return rgb_to_grayscale_image_pil(inpt, num_output_channels=num_output_channels)
else:
Expand Down