perform out of bounds check for single values and two tuples in ColorJitter #7133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Jan 26, 2023
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks Philip, some nits but LGTM anyway.
As an extra NIT: do we want to / should we raise and error if a tuple is passed while center has a non-default value? Does it matter?
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
… in ColorJitter (#7133) Reviewed By: vmoens Differential Revision: D43116120 fbshipit-source-id: f2a73099f2246862d157d3aef6b7b03ceebfaf82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7132.
cc @vfdev-5