Add missing type hints to ColorJitter constructor #7087
Conversation
|
Hi @RoiEXLab! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
torchvision/transforms/transforms.py
Outdated
| def __init__(self, brightness=0, contrast=0, saturation=0, hue=0): | ||
| def __init__( | ||
| self, | ||
| brightness: "float | tuple[float, float]" = 0, |
There was a problem hiding this comment.
As far as I know, using the | operator for Union is only supported starting Python 3.10. See PEP604 for details. Is this the reason you are using string annotations here?
There was a problem hiding this comment.
Kind of. I think using tuple[float] instead of Tuple[float] from typings does not work on python 3.8 either (which I'm still using).
There was a problem hiding this comment.
Yeah, our minimum version is 3.7 so we'll have to abide by that.
|
@pmeier Changed the hints accordingly. Should work now. Some of the CI on some systems is failing, but I'm pretty sure it's not related to this PR |
|
The CircleCI failures are unrelated to this PR. I've started the GHA ones. Let's see if everything is green there as well. If so, we can merge. |
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: YosuaMichael Differential Revision: D42706910 fbshipit-source-id: 93184ccbd1e81a20d04834244457870c32dde768
3 participants
Hi,
just a small change to make automatic type inheritance a little bit more pleasant for some people.
cc @vfdev-5 @datumbox