Skip to content

Conversation

@NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Dec 1, 2022

Copy link
Contributor

@YosuaMichael YosuaMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However lets wait for the internal diff: https://www.internalfb.com/diff/D41648542 to be committed before merging this PR since if we can't commit that diff we should modify it and add [FBCode->GH] tags for this PR.

@NicolasHug NicolasHug merged commit 264b83b into pytorch:main Dec 1, 2022
facebook-github-bot pushed a commit that referenced this pull request Dec 12, 2022
)

Reviewed By: datumbox

Differential Revision: D41836899

fbshipit-source-id: a362b94269e02fdef8b009cb855b833c5cc2b11b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants