[reland] rename DisableTorchFunction to DisableTorchFunctionSubclass (#88218) #6958
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D41268423 |
|
@samdow Looks good. Please give us a ping when you actually land everything. We will need to export the patch to Github to avoid breaking the CI. :) |
…ytorch#88218) (pytorch#89221) Summary: Pull Request resolved: pytorch#89221 X-link: pytorch/vision#6958 First half of pytorch#87990. This doesn't change any of the behavior and is just a rename Test Plan: OSS Reviewed By: zou3519 Differential Revision: D41268423 fbshipit-source-id: eaf1bb057ef09bbd0334ac9e8f7bc0cd32fc7254
|
Thanks @datumbox! Just wanted to let you know that I didn't realize but this change updates a file that's under a code freeze, so I'm going to hold off on it until the new year |
|
@samdow Thanks for the heads up, sounds good! |
|
This pull request was exported from Phabricator. Differential Revision: D41268423 |
samdow
force-pushed
the
export-D41268423-to-fbsync
branch
from
f9f4117 to
57d1694
Compare
…(#88218) (#89221) Summary: X-link: pytorch/pytorch#89221 Pull Request resolved: pytorch#6958 First half of #87990. This doesn't change any of the behavior and is just a rename Reviewed By: zou3519 Differential Revision: D41268423 fbshipit-source-id: c600da00f393ae4a3176fdbcbde6d1e0b5ec6347
…(#88218) (#89221) Summary: X-link: pytorch/pytorch#89221 Pull Request resolved: pytorch#6958 First half of #87990. This doesn't change any of the behavior and is just a rename Reviewed By: zou3519 Differential Revision: D41268423 fbshipit-source-id: 04ce30bcbe186096e467467dad2784560bd8a96d
|
This pull request was exported from Phabricator. Differential Revision: D41268423 |
samdow
force-pushed
the
export-D41268423-to-fbsync
branch
from
57d1694 to
1f2ab5e
Compare
…ytorch#88218) (pytorch#89221) Summary: Pull Request resolved: pytorch#89221 X-link: pytorch/vision#6958 First half of pytorch#87990. This doesn't change any of the behavior and is just a rename Test Plan: OSS Reviewed By: zou3519 Differential Revision: D41268423 fbshipit-source-id: 14552a1b3a0ac5de60466ad888ec55f03a64253f
…(#88218) (#89221) Summary: X-link: pytorch/pytorch#89221 Pull Request resolved: #6958 First half of #87990. This doesn't change any of the behavior and is just a rename Reviewed By: zou3519 Differential Revision: D41268423 fbshipit-source-id: 44929eaac1aec2bd320697536f8cdc918643d6a9
|
@fmassa @NicolasHug Vasilis asked me to ping when we landed so you can update CI. Since he's moved on, I was hoping one of you is the right person to do this (or know the right people). Thanks! |
|
@samdow Thanks for the ping. It seems that the commit (972e5a7) landed on fbsync branch. @YosuaMichael @jdsgomes @pmeier Could you cherrypick it on main? |
|
Can I do that as non-meta employee? If yes, do I just send a PR with the commit in question against |
|
@pmeier Yes you can. We just need to bring the specific commit on main branch and you are good to go. Just make sure you add on the PR title AND at the beginning of the commit message the We should do this after the nightly is out to fix our CI which will probably break. |
|
See #7062 |
|
#7062 landed, so I guess we can close this? |
|
Thanks all |
5 participants
Summary: First half of #87990. This doesn't change any of the behavior and is just a rename
Differential Revision:
D41268423
LaMa Project: L1098534