add dispatch tests for prototype transform dispatchers #6631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Sep 22, 2022
Comment on lines
+50
to
+52
| for attribute in feature_type.__annotations__.keys(): | ||
| if attribute in args_kwargs.kwargs: | ||
| del args_kwargs.kwargs[attribute] |
Contributor
Author
There was a problem hiding this comment.
This removes metadata like image_size or format from the sample inputs. They are only there in the first place since we are using the sample inputs of the kernels for the dispatcher.
Contributor
|
Merge conflicts have to resolved and then good to go |
Conflicts: test/prototype_transforms_dispatcher_infos.py
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Reviewed By: datumbox Differential Revision: D40138747 fbshipit-source-id: c524b3296d9cb3aaa667fabf2d0bb21707ba2c24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 2. from #6622.