Skip to content

Progress Bar for download_url #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soumith merged 5 commits into from
May 11, 2018
Merged

Progress Bar for download_url #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a754f3
Added Progress Bar to the dataset downloading utility
maruthgoyal May 10, 2018
5c8b995
Updated progressbar to update by blcoks
maruthgoyal May 11, 2018
3279d4a
Added progressbar2 to the requirements
maruthgoyal May 11, 2018
b489169
fixed style issues
maruthgoyal May 11, 2018
ef80ba2
Shifted from progressbar to tqdm
maruthgoyal May 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ def find_version(*file_paths):
'pillow >= 4.1.1',
'six',
'torch',
'tqdm'
]

setup(
Expand Down
11 changes: 10 additions & 1 deletion torchvision/datasets/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
import os.path
import hashlib
import errno
from tqdm import tqdm


def gen_bar_updator(pbar):
def bar_update(count, block_size, total_size):
pbar.total = total_size / block_size
pbar.update(count)

return bar_update


def check_integrity(fpath, md5):
Expand Down Expand Up @@ -38,7 +47,7 @@ def download_url(url, root, filename, md5):
else:
try:
print('Downloading ' + url + ' to ' + fpath)
urllib.request.urlretrieve(url, fpath)
urllib.request.urlretrieve(url, fpath, reporthook=gen_bar_updator(tqdm()))
except:
if url[:5] == 'https':
url = url.replace('https:', 'http:')
Expand Down