-
Notifications
You must be signed in to change notification settings - Fork 632
Add CI for Autoparallel experiment llama3 on 4 GPUs #2105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stack-info: PR: #2105, branch: xmfan/stack/5
| @@ -0,0 +1,56 @@ | |||
| name: Auto Parallel 8 GPU Integration Tests | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern across the other workflows seems to still be naming this 8 GPU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC it basically says we have at most 8 GPU used in each integration tests (and we only have 8 available)
| "llama3_autoparallel_fsdp_tp", | ||
| ngpu=4, | ||
| ), | ||
| # TODO: Re-enable this once we fix the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work yet, I'm thinking of enabling it in a different PR
tianyu-l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm, except that the test is not passing?
stack-info: PR: #2105, branch: xmfan/stack/5
stack-info: PR: #2105, branch: xmfan/stack/5
|
Test will pass after meta-pytorch/autoparallel#274 |
tianyu-l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
Stacked PRs:
Validated with
python -m torchtitan.experiments.auto_parallel.tests.integration_tests artifacts-to-be-uploaded --ngpu 4