-
Notifications
You must be signed in to change notification settings - Fork 662
Validate tokenizer and model alignment before training #2074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CryptoSalamander
wants to merge
7
commits into
pytorch:main
Choose a base branch
from
CryptoSalamander:add-tokenizer-validator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
59dc807
Validate tokenizer and model alignment before training
CryptoSalamander faa2122
Update tokenizer-model alignment validation logic
CryptoSalamander 50b10b8
Remove unused `eos_id` from model args
CryptoSalamander 883c281
Revert removal of eos_id_args
CryptoSalamander cdc1f1b
Rename validate_tokenizer_model_alignment to compatibility
CryptoSalamander 31853e8
Remove unused eos_id from model args (except transformers_backend)
CryptoSalamander 24557cf
Update function name and type hint
CryptoSalamander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type hint field should not be surrounded by quotation mark?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wwwjn Thanks for pointing this out! I originally wrote it this way to avoid potential circular import issues. (like https://github.com/pytorch/torchtitan/blob/main/torchtitan/components/metrics.py#L496)
However, after testing on Python 3.10 and above, it seems to work fine without the quotation marks, so I’ve updated the code accordingly.