Skip to content

[HUD] navbar metrics section to use grouped dropdown component #7519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[HUD] navbar metrics section to use grouped dropdown component #7519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c09455
metrics dropdown
clee2000 Nov 26, 2025
c4ab372
remove unused component
clee2000 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 28 additions & 83 deletions torchci/components/layout/NavBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,91 +1,11 @@
import { benchmarkNavGroup } from "components/benchmark_v3/pages/BenchmarkListPage";
import styles from "components/layout/NavBar.module.css";
import Link from "next/link";
import React, { useState } from "react";
import { AiFillGithub } from "react-icons/ai";
import ThemeModePicker from "../common/ThemeModePicker";
import LoginSection from "./LoginSection";
import { NavBarGroupDropdown, NavItem } from "./NavBarGroupDropdown";

const NavBarDropdown = ({
title,
items,
}: {
title: string;
items: any;
}): JSX.Element => {
const [dropdown, setDropdown] = useState(false);
const dropdownStyle = dropdown ? { display: "block" } : {};
const firstItemHref = items.length > 0 ? items[0].href : "#";

// Check if device is touch-enabled
const isTouchDevice = React.useMemo(
() =>
typeof window !== "undefined" &&
("ontouchstart" in window || navigator.maxTouchPoints > 0),
[]
);

// Set dropdown state only on non-touch devices
const setDropdownIfNotTouch = (value: boolean) => {
if (!isTouchDevice) {
setDropdown(value);
}
};

// Close dropdown when clicking outside
React.useEffect(() => {
const handleClickOutside = (event: MouseEvent) => {
const target = event.target as HTMLElement;
if (!target.closest(`.${styles.dropdownContainer}`)) {
setDropdown(false);
}
};

if (dropdown) {
document.addEventListener("click", handleClickOutside);
return () => {
document.removeEventListener("click", handleClickOutside);
};
}
}, [dropdown]);

return (
<li
onMouseEnter={() => setDropdownIfNotTouch(true)}
onMouseLeave={() => setDropdownIfNotTouch(false)}
style={{ padding: 0 }}
className={`${styles.dropdownContainer} ${
dropdown ? styles.dropdownOpen : ""
}`}
>
<Link
href={firstItemHref}
prefetch={false}
className={styles.dropdowntitle}
onClick={(e) => {
if (isTouchDevice) {
// otherwise the menu will close immediately on touch devices
e.preventDefault();
}
setDropdown(!dropdown);
}}
>
{title} ▾
</Link>
<ul className={styles.dropdown} style={dropdownStyle}>
{items.map((item: any) => (
<li key={item.href}>
<Link href={item.href} prefetch={false}>
{item.name}
</Link>
</li>
))}
</ul>
</li>
);
};

function NavBar() {
const benchmarkDropdown = benchmarkNavGroup;

Expand Down Expand Up @@ -185,7 +105,11 @@ function NavBar() {
name: "vLLM CI metrics",
href: "/metrics/vllm",
},
];
].map((item) => ({
label: item.name,
route: item.href,
type: "item" as const,
}));

return (
<div className={styles.navbar}>
Expand Down Expand Up @@ -247,8 +171,29 @@ function NavBar() {
KPIs
</Link>
</li>
<NavBarGroupDropdown title="Benchmarks" items={benchmarkDropdown} />{" "}
<NavBarDropdown title="Metrics" items={metricsDropdown} />
<NavBarGroupDropdown title="Benchmarks" items={benchmarkDropdown} />
<NavBarGroupDropdown
title={
<Link
href="/metrics"
prefetch={false}
onClick={(e) => {
const isTouchDevice =
typeof window !== "undefined" &&
("ontouchstart" in window || navigator.maxTouchPoints > 0);
if (isTouchDevice) {
e.preventDefault();
}
}}
>
Metrics ▾
</Link>
}
// showCarrot false since the spacing is unusual if we use the
// default
showCarrot={false}
items={metricsDropdown}
/>
<NavBarGroupDropdown title="Dev Infra" items={devInfraDropdown} />
<li
style={{ cursor: "pointer", display: "flex", alignItems: "center" }}
Expand Down