[HUD] nav bar login section to use grouped dropdown component #7518
+95
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
clee2000
changed the title
Contributor
|
there is error for ur pr |
clee2000
force-pushed
the
csl/navbar_stuff_2
branch
from
82789f4 to
d7f345e
Compare
Contributor
Author
oops sorry fixed |
yangw-dev
approved these changes
Dec 2, 2025
clee2000
added a commit
that referenced
this pull request
Dec 4, 2025
Requires #7518 Changes the metrics dropdown to use the grouped dropdown component Also remove the old component since there are no more usages after removing this one I checked that on touchscreen, tapping metrics doesn't navigate to the metrics page but opens the dropdown, which makes the old behavior Old: <img width="242" height="230" alt="image" src="https://github.com/user-attachments/assets/93c8822d-e0cf-43b1-ad99-65790aa03e73" /> New: <img width="300" height="161" alt="image" src="https://github.com/user-attachments/assets/fb9108e6-0223-447a-b771-d3ccc1a1d4a8" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was using it's own custom one, now it reuses a different one
Also changes NavBarGroupDropdown so it can use a jsx element as the label/the dropdown display item
Old:
Need to click the icon to get the dropdown, also need to click to close it
New:
Hover to see the drop down
Related: #7491
#7490