Refactor type hints in events.py to use Python 3.10+ syntax#3510
Merged
vfdev-5 merged 1 commit intopytorch:masterfrom Feb 4, 2026
Merged
Refactor type hints in events.py to use Python 3.10+ syntax#3510vfdev-5 merged 1 commit intopytorch:masterfrom
vfdev-5 merged 1 commit intopytorch:masterfrom
Conversation
Fix type hinting in State class for event_to_attr and update __repr__ method to use __dict__ Fix formatting of comments in State class for clarity
vfdev-5
approved these changes
Feb 4, 2026
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks @aaishwarymishra !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates type annotations in
ignite/engine/events.pyto use Python 3.10+ union syntax (X | Y) and built-in generics (e.g.,list,dict) instead of the oldertypingmodule aliases. The changes improve code readability and modernize the codebase, but do not affect runtime behavior.part of issue #3481