Update type hints in handlers/base_logger.py to to Python 3.10+ syntax#3505
Open
rwtarpit wants to merge 7 commits intopytorch:masterfrom
Open
Update type hints in handlers/base_logger.py to to Python 3.10+ syntax#3505rwtarpit wants to merge 7 commits intopytorch:masterfrom
rwtarpit wants to merge 7 commits intopytorch:masterfrom
Conversation
vfdev-5
reviewed
Feb 3, 2026
vfdev-5
reviewed
Feb 3, 2026
ignite/handlers/base_logger.py
Outdated
| raise TypeError( | ||
| "Argument optimizer should be torch.optim.Optimizer or has attribute 'param_groups' as list/tuple, " | ||
| f"but given {type(optimizer)}" | ||
| (f"but given {type(optimizer)}") |
Collaborator
There was a problem hiding this comment.
Suggested change
| (f"but given {type(optimizer)}") | |
| f"but given {type(optimizer)}" |
ignite/handlers/base_logger.py
Outdated
|
|
||
| def close(self) -> None: | ||
| pass | ||
|
No newline at end of file |
Collaborator
There was a problem hiding this comment.
This change should be reverted as well
rwtarpit
force-pushed
the
master
branch
2 times, most recently
from
e53bbde to
264c6dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3481 for handlers/base_logger.py