Skip to content

test: use absolute tolerance in FID test to account for float32 numer… #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vfdev-5 merged 6 commits into from
Apr 22, 2025
+2 −2
Merged

test: use absolute tolerance in FID test to account for float32 numer… #3390

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
feb68cc
test: use absolute tolerance in FID test to account for float32 numer…
BanzaiTokyo Apr 22, 2025
195dab9
increase the tolerance
BanzaiTokyo Apr 22, 2025
165698b
decrease eps
BanzaiTokyo Apr 22, 2025
b627a67
Update tests/ignite/metrics/gan/test_fid.py
vfdev-5 Apr 22, 2025
aa874b7
revert _eps size to 1e-6 and set tolerance to 5e-4 om MPS
BanzaiTokyo Apr 22, 2025
50fe168
Merge branch 'master' into fixes_tolerance_fid_test
vfdev-5 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/ignite/metrics/gan/test_fid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ def test_compute_fid_from_features(available_device):
mu1, sigma1 = train_samples.mean(axis=0), cov(train_samples, rowvar=False)
mu2, sigma2 = test_samples.mean(axis=0), cov(test_samples, rowvar=False)

tol = 1e-4 if available_device == "mps" else 1e-5
tol = 5e-4 if available_device == "mps" else 1e-5
assert (
pytest.approx(pytorch_fid_score.calculate_frechet_distance(mu1, sigma1, mu2, sigma2), rel=tol)
pytest.approx(pytorch_fid_score.calculate_frechet_distance(mu1, sigma1, mu2, sigma2), abs=tol)
== fid_scorer.compute()
)

Expand Down
Loading