Skip to content

Conversation

@BanzaiTokyo
Copy link
Contributor

No description provided.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 27, 2025

Failure is unrelated but the PR changed the random seed such that this data generation line:

torch.stack([torch.sin(y[:, 0]), torch.cos(y[:, 1]), torch.exp(y[:, 2])], dim=1)

produces large values, e.g. 5.8325e+19
https://github.com/pytorch/ignite/actions/runs/14106287496/job/39513534420?pr=3358#step:11:7644

@BanzaiTokyo Can you try to fix data generation part as following:

 torch.stack([torch.sin(y[:, 0]), torch.cos(y[:, 1]), torch.exp(y[:, 2]) / 10], dim=1)

@BanzaiTokyo BanzaiTokyo force-pushed the test_entropy_available_device branch from dc6146f to 9410e68 Compare March 27, 2025 15:23
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks !

@vfdev-5 vfdev-5 enabled auto-merge (squash) March 27, 2025 16:12
@vfdev-5 vfdev-5 merged commit fd85588 into pytorch:master Mar 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants