Skip to content

Update test_average_precision.py to resolve issue #3335 #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vfdev-5 merged 4 commits into from
Feb 28, 2025
Merged

Update test_average_precision.py to resolve issue #3335 #3337

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70f5d7c
Update test_average_precision.py to resolve issue #3335
puhuk Feb 27, 2025
a548bcf
Update test_average_precision.py
puhuk Feb 27, 2025
97e3de0
Merge branch 'master' into test_average_precision_device
vfdev-5 Feb 27, 2025
b1f2e1d
Merge branch 'master' into test_average_precision_device
vfdev-5 Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions tests/ignite/metrics/test_average_precision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ def test_no_update():
ap.compute()


def test_input_types():
ap = AveragePrecision()
def test_input_types(available_device):
ap = AveragePrecision(device=available_device)
ap.reset()
output1 = (torch.rand(4, 3), torch.randint(0, 2, size=(4, 3), dtype=torch.long))
ap.update(output1)
Expand All @@ -50,8 +50,8 @@ def test_input_types():
ap.update((torch.randint(0, 2, size=(10,)).long(), torch.randint(0, 2, size=(10, 5)).long()))


def test_check_shape():
ap = AveragePrecision()
def test_check_shape(available_device):
ap = AveragePrecision(device=available_device)

with pytest.raises(ValueError, match=r"Predictions should be of shape"):
ap._check_shape((torch.tensor(0), torch.tensor(0)))
Expand Down Expand Up @@ -82,9 +82,9 @@ def test_data_binary_and_multilabel(request):


@pytest.mark.parametrize("n_times", range(5))
def test_binary_and_multilabel_inputs(n_times, test_data_binary_and_multilabel):
def test_binary_and_multilabel_inputs(n_times, available_device, test_data_binary_and_multilabel):
y_pred, y, batch_size = test_data_binary_and_multilabel
ap = AveragePrecision()
ap = AveragePrecision(device=available_device)
ap.reset()
if batch_size > 1:
n_iters = y.shape[0] // batch_size + 1
Expand Down Expand Up @@ -115,7 +115,9 @@ def test_data_integration_binary_and_multilabel(request):


@pytest.mark.parametrize("n_times", range(5))
def test_integration_binary_and_mulitlabel_inputs(n_times, test_data_integration_binary_and_multilabel):
def test_integration_binary_and_mulitlabel_inputs(
n_times, available_device, test_data_integration_binary_and_multilabel
):
y_pred, y, batch_size = test_data_integration_binary_and_multilabel

def update_fn(engine, batch):
Expand All @@ -126,7 +128,7 @@ def update_fn(engine, batch):

engine = Engine(update_fn)

ap_metric = AveragePrecision()
ap_metric = AveragePrecision(device=available_device)
ap_metric.attach(engine, "ap")

np_y = y.numpy()
Expand Down