Helper function all_gather_tensors_with_shapes()#3281
Merged
vfdev-5 merged 8 commits intopytorch:masterfrom Sep 5, 2024
Merged
Conversation
vfdev-5
reviewed
Sep 4, 2024
allgather_tensors_with_defferent_shapes()all_gather_tensors_with_shapes()
vfdev-5
reviewed
Sep 4, 2024
vfdev-5
reviewed
Sep 4, 2024
Co-authored-by: vfdev <[email protected]>
…-tensors-with-different-shapes' into feature-allgather-tensors-with-different-shapes
vfdev-5
reviewed
Sep 4, 2024
vfdev-5
reviewed
Sep 4, 2024
vfdev-5
reviewed
Sep 5, 2024
| if isinstance(_model, _SerialModel) or group == dist.GroupMember.NON_GROUP_MEMBER: | ||
| return [tensor] | ||
|
|
||
| max_shape = torch.tensor(shapes).amax(dim=0) |
Collaborator
There was a problem hiding this comment.
I wonder whether we could actually get tensor shapes using all_gather such that shapes arg can be optional ?
Collaborator
Author
There was a problem hiding this comment.
Yes we can. Do you want it in this PR?
Collaborator
There was a problem hiding this comment.
Up to you, if you would like it in another PR, OK to me as well
Collaborator
There was a problem hiding this comment.
Let's make it in another PR, I'll merge this one as CI is green
Collaborator
|
@sadra-barikbin there is a related to this PR failure on HVD GPU CI: https://github.com/pytorch/ignite/actions/runs/10769410690/job/29860560970?pr=3283 Can you please check what happens? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.