refactor: remove redundant line as .reset() is call in Metrics().__init()#3044
Merged
vfdev-5 merged 3 commits intopytorch:masterfrom Aug 24, 2023
Merged
refactor: remove redundant line as .reset() is call in Metrics().__init()#3044vfdev-5 merged 3 commits intopytorch:masterfrom
vfdev-5 merged 3 commits intopytorch:masterfrom
Conversation
vfdev-5
approved these changes
Aug 24, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, if mypy check wont complain
Contributor
Author
|
Do we even know why the kernel is recreated in the reset method ? I think I removed it on the wrong line. It should only be called in init(). |
Collaborator
|
Yes, you are right, we do not need to recreate the kernel on reset. |
vfdev-5
approved these changes
Aug 24, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix @MarcBresson !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same line was in reset() and init() which is unecessary.
Check list: