-
-
Notifications
You must be signed in to change notification settings - Fork 666
Fix for wrong output of Discord Extension and Workflow #3014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6f86348
Added discuss_on_discord extension
guptaaryan16 6b996f5
Added workflow to create threads for help wanted issues on discord
guptaaryan16 07674d4
Update .github/workflows/discord_issues.yml
guptaaryan16 7ceef23
Merge branch 'pytorch:master' into discord
guptaaryan16 118db01
Merge branch 'master' of github.com:guptaaryan16/ignite into discord
guptaaryan16 1e15482
Added check for non-maintainer based PRs to discuss in discord
guptaaryan16 b7d6208
Changed the set-output type pattern
guptaaryan16 24929a2
Update .github/workflows/discord_issues.yml
guptaaryan16 3e8bb0f
Adding right destination for discord channel
guptaaryan16 6c0fcd0
Update Non-maintainers requirement in discord_issues.yml
guptaaryan16 efb7f59
Fixed the issue in Discord workflow
guptaaryan16 619c65b
Merge branch 'master' of github.com:guptaaryan16/ignite into discord
guptaaryan16 cb714a9
Update .github/workflows/discord_issues.yml
guptaaryan16 ea59921
Update .github/workflows/discord_pull_requests.yaml
guptaaryan16 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: Discuss on Discord | ||
| name: Discuss "help-wanted" issue on Discord | ||
|
|
||
| on: | ||
| issues: | ||
|
|
@@ -11,8 +11,7 @@ on: | |
| inputs: | ||
| issue_number: | ||
| description: 'Issue number' | ||
| pull_request_number: | ||
| description: 'Pull request number' | ||
| required: true | ||
|
|
||
| permissions: | ||
| issues: write | ||
|
|
@@ -23,7 +22,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Discuss on Discord-Issues" | ||
| if: github.event.issue && contains(github.event.issue.labels.*.name, 'help wanted') | ||
| if: ${{ github.event.label.name == 'help wanted' }} | ||
| uses: EndBug/[email protected] | ||
| with: | ||
| discord_bot_token: ${{ secrets.DISCORD_BOT_TOKEN }} | ||
|
|
@@ -32,13 +31,4 @@ jobs: | |
| issue_comment: Hey 👋, I've just created a [thread]($THREAD_LINK$) for this issue on [PyTorch-Ignite Discord](https://pytorch-ignite.ai/chat) where you can quickly talk to the community on the topic. | ||
| discord_message: New issue created in `${{ github.repository }}`:<https://github.com/${{ github.repository }}/issues/${{ github.event.issue.number }}> | ||
|
|
||
| - name: "Discuss on Discord-PR (Non-maintainer only)" | ||
| if: github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'help wanted') | ||
| uses: EndBug/[email protected] | ||
| with: | ||
| discord_bot_token: ${{ secrets.DISCORD_BOT_TOKEN }} | ||
| destination: ${{ secrets.DISCORD_BOT_DESTINATION }} | ||
| issue_number: ${{ github.event.inputs.pull_request_number || github.event.pull_request.number }} | ||
| issue_comment: Hey 👋, I've just created a [thread]($THREAD_LINK$) for this pull request on [PyTorch-Ignite Discord](https://pytorch-ignite.ai/chat) where you can quickly talk to the community on the topic. | ||
| discord_message: New PR created in `${{ github.repository }}`:<https://github.com/${{ github.repository }}/pull/${{ github.event.pull_request.number }}> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Discuss "help-wanted" PR on Discord | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - labeled | ||
| workflow_dispatch: | ||
| inputs: | ||
| pull_request_number: | ||
| description: 'Pull request number' | ||
|
|
||
| permissions: | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| discord: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Discuss on Discord-PR (Non-maintainer only)" | ||
| if: ${{ github.event.label.name == 'help wanted' }} | ||
| uses: EndBug/[email protected] | ||
| with: | ||
| discord_bot_token: ${{ secrets.DISCORD_BOT_TOKEN }} | ||
| destination: ${{ secrets.DISCORD_BOT_DESTINATION }} | ||
| issue_number: ${{ github.event.inputs.pull_request_number || github.event.pull_request.number }} | ||
| issue_comment: Hey 👋, I've just created a [thread]($THREAD_LINK$) for this pull request on [PyTorch-Ignite Discord](https://pytorch-ignite.ai/chat) where you can quickly talk to the community on the topic. | ||
| discord_message: New PR created in `${{ github.repository }}`:<https://github.com/${{ github.repository }}/pull/${{ github.event.pull_request.number }}> | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.