Skip to content

Add support for MPS Backend [without torch.amp.autocast ]#2993

Merged
vfdev-5 merged 7 commits intopytorch:mpsfrom
guptaaryan16:mps
Aug 23, 2023
Merged

Add support for MPS Backend [without torch.amp.autocast ]#2993
vfdev-5 merged 7 commits intopytorch:mpsfrom
guptaaryan16:mps

Conversation

@guptaaryan16
Copy link
Contributor

Fixes #2977

Description: I have added support for mps devices through this PR and currently it uses (https://pytorch.org/docs/stable/notes/mps.html). Right now I have not just integrated any CI but it is in progress.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added module: distributed Distributed module module: engine Engine module labels Jul 12, 2023
@guptaaryan16 guptaaryan16 changed the title Add support forMPS Backend [without torch.amp.autocast ] Add support for MPS Backend [without torch.amp.autocast ] Jul 12, 2023
@guptaaryan16 guptaaryan16 marked this pull request as draft July 12, 2023 11:33
@vfdev-5 vfdev-5 changed the base branch from master to mps August 23, 2023 09:00
@vfdev-5 vfdev-5 marked this pull request as ready for review August 23, 2023 09:00
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guptaaryan16 , I'll merge this PR into "mps" branch and later will fix all CI related issues and also add more mps tests.

@vfdev-5 vfdev-5 merged commit b0b0fe4 into pytorch:mps Aug 23, 2023
vfdev-5 added a commit that referenced this pull request Nov 22, 2023
* Add support for `MPS` Backend [without torch.amp.autocast ] (#2993)

* Add support for "mps" device in ignite.distributed.base

* Made changes in the supervised_trainer API to have mps devices, Added some tests

* autopep8 fix

* Added lint fixes

* Setup ci for mps tests

---------

Co-authored-by: guptaaryan16 <[email protected]>
Co-authored-by: vfdev <[email protected]>

* Fixed mps-tests.yml

* More fixes to mps-tests.yml

* Set up working directory in mps yml

* another try

* another try

* another try

* added version check and skipped mps tests

* code formatting

* another code formatting fix

---------

Co-authored-by: Aryan Gupta <[email protected]>
Co-authored-by: guptaaryan16 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: distributed Distributed module module: engine Engine module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with using "mps" device

2 participants