Skip to content

[Follow-up] Account for BC in PR#2947 #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vfdev-5 merged 5 commits into from
Jun 21, 2023
Merged

[Follow-up] Account for BC in PR#2947 #2967

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf7d752
Account for BC
sadra-barikbin Jun 20, 2023
d265eb9
Remove an unnecessary stmt
sadra-barikbin Jun 20, 2023
ee45901
Merge branch 'master' into Follow-up-account-for-BC-in-native-allgather
vfdev-5 Jun 21, 2023
4b87b66
Merge branch 'master' into Follow-up-account-for-BC-in-native-allgather
vfdev-5 Jun 21, 2023
adfaf70
Merge branch 'master' into Follow-up-account-for-BC-in-native-allgather
vfdev-5 Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ignite/distributed/comp_models/native.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,12 +438,16 @@ def _do_all_gather(self, tensor: torch.Tensor, group: Optional[Any] = None) -> t
group_size = group.size()
elif isinstance(group, list):
group_size = len(group)
group = self._do_new_group(group)
else:
raise ValueError("Argument group should be list of int or ProcessGroup")
if tensor.ndimension() == 0:
tensor = tensor.unsqueeze(0)
output = [torch.zeros_like(tensor) for _ in range(group_size)]
dist.all_gather(output, tensor, group=group)
if group is not None:
dist.all_gather(output, tensor, group=group)
else:
dist.all_gather(output, tensor)
return torch.cat(output, dim=0)

def _do_new_group(self, ranks: List[int], **kwargs: Any) -> Any:
Expand Down