Add new metric usages and update RunningAverage accordingly#2958
Conversation
github-actions
bot
added
docs
module: contrib
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR, @sadra-barikbin !
I left several comments to improve the code and the API
Also a few improvements
and add test for SingleEpochRunningBatchWise in test_metric
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
@sadra-barikbin thanks for the update, there is a nit improvement for docstring. I'll check tests in more details a bit later.
Please also fix current problem with docs rendering:
https://app.netlify.com/sites/pytorch-ignite-preview/deploys/647cf10085384f0008aea77c
11:02:30 PM: reading sources... [100%] metrics .. utils
11:02:30 PM: /opt/build/repo/ignite/metrics/running_average.py:docstring of ignite.metrics.running_average.RunningAverage:8: ERROR: Unknown interpreted text role "method".
11:02:30 PM: looking for now-outdated files... none found
What do you mean by "nit"? |
It's an expression to say a tiny improvement, I'm talking about this:#2958 (comment) |
sadra-barikbin
force-pushed
the
Improvement-in-metric-usage-and-RunningAverage
branch
from
ced1af8 to
941a524
Compare
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Great work, thanks @sadra-barikbin
I left few other comments to update the code and it will be good to go
…tric-usage-and-RunningAverage' into Improvement-in-metric-usage-and-RunningAverage
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks @sadra-barikbin !
2 participants
Description:
Check list: