Skip to content

[follow-up] NeptuneSaver fixes #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vfdev-5 merged 9 commits into from
Mar 31, 2023
Merged

[follow-up] NeptuneSaver fixes #2902

vfdev-5 merged 9 commits into from
Mar 31, 2023

Conversation

@kshitij12345
Copy link
Contributor

@kshitij12345 kshitij12345 commented Mar 29, 2023

Fixes

  • Correctly rewind the temporary files buffer.
  • Correctly remove the file from a run. delete_files is not supported on Run object.
  • Update the saver doc to reflect that Windows is not supported (as TemporaryFile and NamedTemporaryFile don't work correctly on Windows)

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: contrib Contrib module label Mar 29, 2023
@kshitij12345 kshitij12345 marked this pull request as ready for review March 30, 2023 06:10
@vfdev-5 vfdev-5 enabled auto-merge (squash) March 31, 2023 09:21
vfdev-5
vfdev-5 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kshiteej!

@vfdev-5 vfdev-5 merged commit 28c3802 into pytorch:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: contrib Contrib module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kshitij12345 @vfdev-5