Issue#2853: Update once_event_filter in events.py#2858
Issue#2853: Update once_event_filter in events.py#2858vfdev-5 merged 11 commits intopytorch:masterfrom
Conversation
|
@vfdev-5 thank you for reviewing the PR. I will make the changes as stated above and add unit tests. |
|
@DeepC004 there are code formatting issues: Please run the following locally to fix it: bash ./tests/run_code_style.sh install
bash ./tests/run_code_style.sh fmtHowever, the following errors should be fixed manually: |
|
@DeepC004 please run |
I ran the code for formatting the files. The issue is length of some lines is greater than the maximum line length limit. It turns out to be a line for returning the error comment, which I believe can be written in more concise manner. |
|
Let me restart the CI by closing and reopening the PR |
|
@vfdev-5 thanks for helping me out throughout the PR. I will remember to consider small details like line length limit and junk whitespaces while contributing. This was my first merged PR, sorry incase I bugged you with doubts and code errors :D |
|
@DeepC004 thanks for your contribution and no worries about code formatting, this can be painful in the beginning ! Hope to see more of your contributions 👍 |
Related to #2853
Description:
Check list: