-
-
Notifications
You must be signed in to change notification settings - Fork 666
Fix sync_all_reduce to consider update->compute->update case
#2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vfdev-5
merged 26 commits into
pytorch:master
from
sadra-barikbin:Fix-sync_all_reduce-decorator-to-consider-compute-update-compute-case
Feb 17, 2023
+100
−41
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
4bde2eb
Fix sync_all_reduce
sadra-barikbin f174e7d
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin 83dd16e
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin f9970d3
Make _is_reduced no-op, add a test and a little improvement
sadra-barikbin f5b434e
Make _is_reduced no-op, add a test and a little improvement
sadra-barikbin 1bf75bb
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin 2f0d9a6
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin ea2474e
Fix Mypy
sadra-barikbin 74515fe
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin 319f0f6
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
vfdev-5 392a191
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin cdc7e5a
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin ca391f9
Remove some asserts from test_loss & test_accuracy
sadra-barikbin fb8b431
Fix bug
sadra-barikbin 4687414
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin 6ba844f
Remove _is_reduced
sadra-barikbin 086fa72
Merge remote-tracking branch 'upstream/Fix-sync_all_reduce-decorator-…
sadra-barikbin 2c0d020
Revert deleted assertions
sadra-barikbin 67d0833
Fix a bug in precision
sadra-barikbin c048119
Fix a mypy error
sadra-barikbin 3017b8e
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin 3c0f305
Update ignite/metrics/metric.py
sadra-barikbin 20690af
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin c9f474e
Revert a change in test_accuracy
sadra-barikbin ac95fa5
Merge branch 'master' into Fix-sync_all_reduce-decorator-to-consider-…
sadra-barikbin af380f5
Revert a change in test_accuracy exactly
sadra-barikbin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.