Add distributed test to RocCurve metric#2802
Merged
vfdev-5 merged 10 commits intopytorch:masterfrom Feb 16, 2023
Merged
Conversation
vfdev-5
reviewed
Dec 21, 2022
vfdev-5
previously approved these changes
Dec 26, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks @sadra-barikbin !
Collaborator
|
@sadra-barikbin somehow the tests are stuck on nightly ... we have to figure out that |
Collaborator
|
@sadra-barikbin can you check what happens with nightly tests, why they stuck ? |
Collaborator
Author
|
The only test failure is because |
vfdev-5
reviewed
Feb 16, 2023
Collaborator
Yes, this test failure is unrelated. Please address this comment #2802 (comment) and we'll be good to go |
vfdev-5
reviewed
Feb 16, 2023
Collaborator
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RocCurve.computemethod to work in the distributed case.