Skip to content

Update ssim unit test #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vfdev-5 merged 3 commits into from
Dec 8, 2022
Merged

Update ssim unit test #2795

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78c30dd
align ssim with psnr
crj1998 Dec 7, 2022
be893ce
add unit test
crj1998 Dec 8, 2022
9b54bcb
Merge branch 'pytorch:master' into fix_ssim
crj1998 Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/ignite/metrics/test_ssim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ def test_ssim(device, shape, kernel_size, gaussian, use_sample_covariance):
use_sample_covariance=use_sample_covariance,
)

assert isinstance(ignite_ssim, float)
assert np.allclose(ignite_ssim, skimg_ssim, atol=7e-5)
assert isinstance(ignite_ssim, torch.Tensor)
assert np.allclose(ignite_ssim.item(), skimg_ssim, atol=7e-5)


def test_ssim_variable_batchsize():
Expand All @@ -123,7 +123,7 @@ def test_ssim_variable_batchsize():
ssim.reset()
ssim.update((torch.cat(y_preds), torch.cat(y_true)))
expected = ssim.compute()
assert np.allclose(out, expected)
assert np.allclose(out.item(), expected.item())


def _test_distrib_integration(device, tol=1e-4):
Expand Down