Merged
Conversation
vfdev-5
reviewed
Nov 18, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR @sadra-barikbin , overall looks good. I left few comments how to update the code.
sadra-barikbin
force-pushed
the
Refactor-distributed-tests
branch
from
444353b to
0c7100d
Compare
And add a tiny test for wandb_logger
Remove multinode configs and add a desc.
sadra-barikbin
force-pushed
the
Refactor-distributed-tests
branch
from
0c7100d to
1611ed0
Compare
vfdev-5
approved these changes
Nov 21, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for the PR @sadra-barikbin !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added a new fixture called
distributedwhich requesting it by a test, makes the test run for 7 preset distributed configurations.For now this fixture is used in
test_precision.pyand if was successful, we could use it in other test modules.