Skip to content

Fixed RL examples to work with new gym API #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vfdev-5 merged 1 commit into from
Sep 9, 2022
Merged

Fixed RL examples to work with new gym API #2706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions examples/reinforcement_learning/actor_critic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def main(env, args):
def run_single_timestep(engine, timestep):
observation = engine.state.observation
action = select_action(model, observation)
engine.state.observation, reward, done, _ = env.step(action)
engine.state.observation, reward, done, _, _ = env.step(action)
if args.render:
env.render()
model.rewards.append(reward)
Expand All @@ -99,7 +99,8 @@ def initialize(engine):

@trainer.on(EPISODE_STARTED)
def reset_environment_state(engine):
engine.state.observation = env.reset()
torch.manual_seed(args.seed + trainer.state.epoch)
engine.state.observation, _ = env.reset(seed=args.seed + trainer.state.epoch)

@trainer.on(EPISODE_COMPLETED)
def update_model(engine):
Expand Down Expand Up @@ -147,7 +148,5 @@ def should_finish_training(engine):
args = parser.parse_args()

env = gym.make("CartPole-v1")
env.seed(args.seed)
torch.manual_seed(args.seed)

main(env, args)
7 changes: 3 additions & 4 deletions examples/reinforcement_learning/reinforce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def main(env, args):
def run_single_timestep(engine, timestep):
observation = engine.state.observation
action = select_action(model, observation)
engine.state.observation, reward, done, _ = env.step(action)
engine.state.observation, reward, done, _, _ = env.step(action)
if args.render:
env.render()
model.rewards.append(reward)
Expand All @@ -89,7 +89,8 @@ def initialize(engine):

@trainer.on(EPISODE_STARTED)
def reset_environment_state(engine):
engine.state.observation = env.reset()
torch.manual_seed(args.seed + trainer.state.epoch)
engine.state.observation, _ = env.reset(seed=args.seed + trainer.state.epoch)

@trainer.on(EPISODE_COMPLETED)
def update_model(engine):
Expand Down Expand Up @@ -137,7 +138,5 @@ def should_finish_training(engine):
args = parser.parse_args()

env = gym.make("CartPole-v1")
env.seed(args.seed)
torch.manual_seed(args.seed)

main(env, args)