Skip to content

Fixed issue when removing handlers on filtered events#2690

Merged
vfdev-5 merged 6 commits intopytorch:masterfrom
vfdev-5:fix-2684-remove-filtered-handler
Sep 4, 2022
Merged

Fixed issue when removing handlers on filtered events#2690
vfdev-5 merged 6 commits intopytorch:masterfrom
vfdev-5:fix-2684-remove-filtered-handler

Conversation

@vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 2, 2022

Fixes #2684

Description:

  • Fixed issue when removing handlers on filtered events
  • Updated tests
  • Some code formatting to reduce LOC

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: engine Engine module label Sep 2, 2022
@vfdev-5 vfdev-5 enabled auto-merge (squash) September 4, 2022 15:32
@vfdev-5 vfdev-5 disabled auto-merge September 4, 2022 15:39
@vfdev-5 vfdev-5 enabled auto-merge (squash) September 4, 2022 15:39
@vfdev-5 vfdev-5 disabled auto-merge September 4, 2022 16:07
@vfdev-5 vfdev-5 enabled auto-merge (squash) September 4, 2022 16:23
@vfdev-5 vfdev-5 merged commit 5acbaa3 into pytorch:master Sep 4, 2022
@vfdev-5 vfdev-5 deleted the fix-2684-remove-filtered-handler branch September 4, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: engine Engine module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to remove handler attached on filtered event

2 participants