Skip to content

Fix device in checkpoint ZeRO test #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vfdev-5 merged 3 commits into from
Aug 19, 2022
Merged

Fix device in checkpoint ZeRO test #2658

vfdev-5 merged 3 commits into from
Aug 19, 2022

Conversation

@sadra-barikbin
Copy link
Collaborator

@sadra-barikbin sadra-barikbin commented Aug 19, 2022

Fix a bug in that caused failure in GPU tests.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@sadra-barikbin sadra-barikbin changed the title Fix device in test Fix device in checkpoint ZeRO test Aug 19, 2022
vfdev-5
vfdev-5 reviewed Aug 19, 2022
View reviewed changes
vfdev-5
vfdev-5 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@vfdev-5 vfdev-5 merged commit 84fda65 into pytorch:master Aug 19, 2022
vfdev-5 pushed a commit to vfdev-5/ignite that referenced this pull request Aug 22, 2022
@sadra-barikbin @vfdev-5
Fix device in checkpoint ZeRO test (pytorch#2658)
23aef67 
* Fix device in test

* empty commit

* Tensor -> tensor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sadra-barikbin @vfdev-5