Adding link to all the metrics#2468
Closed
sayantan1410 wants to merge 2 commits intopytorch:masterfrom
Closed
Conversation
vfdev-5
reviewed
Feb 15, 2022
vfdev-5
reviewed
Feb 16, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Looks great @sayantan1410 !
Let's now add that all metrics. Can you try to put it into defaults.rst before toggle part ?
cc @DevPranjal
Contributor
|
Yes. That would reduce redundancy in the docstrings. The defaults.rst file is included at the start of examples for almost all the metrics (except those in /ignite/metrics/nlp since we do not need the default setup there) |
Contributor
Author
|
@vfdev-5 Yeah, I will try to do that |
1 task
Contributor
Author
|
Hey, I have done the work related to it in a different PR that is why I am closing this. #2468, this is the extension PR. Extremely sorry for the inconvenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2437
Hey, I have made the changes only for the Accuracy, once it is done correctly I will update it for all the metrics in that style.
Check list: