Switch formatting from black+isort to µfmt (black+µsort)#2460
Merged
vfdev-5 merged 4 commits intopytorch:masterfrom Feb 14, 2022
Merged
Switch formatting from black+isort to µfmt (black+µsort)#2460vfdev-5 merged 4 commits intopytorch:masterfrom
vfdev-5 merged 4 commits intopytorch:masterfrom
Conversation
vfdev-5
reviewed
Feb 14, 2022
Collaborator
vfdev-5
left a comment
There was a problem hiding this comment.
@jreese thanks for the PR ! Yes, ufmt works well in torchvision and maintainers are rather happy with it.
I left a comment and let me see what other maintainers think about the change as code formatting could be rather opinionated :)
vfdev-5
reviewed
Feb 14, 2022
Contributor
Author
|
Rebased onto latest and unified on using |
vfdev-5
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This switches linting, formatting, and pre-commit checks from using black and isort directly to using µfmt, which runs µsort and black as an atomic formatting step. This matches what torchvision uses (pytorch/vision#4384).
Covered files were formatted using
./tests/run_code_style.sh fmtandpre-commit runvalidated the results.Check list: