Improve typing hints for Engine and helper methods#2382
Merged
vfdev-5 merged 2 commits intopytorch:masterfrom Dec 23, 2021
Merged
Improve typing hints for Engine and helper methods#2382vfdev-5 merged 2 commits intopytorch:masterfrom
vfdev-5 merged 2 commits intopytorch:masterfrom
Conversation
louis-she
changed the title
vfdev-5
reviewed
Dec 22, 2021
Contributor
Author
|
@vfdev-5 CI has passed |
vfdev-5
approved these changes
Dec 23, 2021
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR @louis-she !
Ishan-Kumar2
pushed a commit
to Ishan-Kumar2/ignite
that referenced
this pull request
Dec 26, 2021
* add: more hints and docs for create_supervised_trainer * fix: mypy style issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2356
Description:
Check list: