Skip to content

Fixed ClearMLLogger to retrieve current task before trying to create a new one. #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vfdev-5 merged 8 commits into from
Dec 13, 2021
Merged

Fixed ClearMLLogger to retrieve current task before trying to create a new one. #2344

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5cc64d7
fix #2343
H4dr1en Dec 10, 2021
1601e41
update docstring
H4dr1en Dec 10, 2021
3a0f6e8
add comment
H4dr1en Dec 10, 2021
8a28754
fix docstrings
H4dr1en Dec 10, 2021
1f606ca
remove trailing whitespace
H4dr1en Dec 10, 2021
f814ec5
Merge branch 'master' into master
vfdev-5 Dec 10, 2021
b44181c
Merge branch 'master' into master
vfdev-5 Dec 11, 2021
691116b
Merge branch 'master' into master
vfdev-5 Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions ignite/contrib/handlers/clearml_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ class ClearMLLogger(BaseLogger):
kwargs: Keyword arguments accepted from
`clearml.Task
<https://clear.ml/docs/latest/docs/references/sdk/task#taskinit>`_.
All arguments are optional.
All arguments are optional. If a ClearML has already been created,
kwargs will be ignored and the current task will be used.

Examples:
.. code-block:: python
Expand Down Expand Up @@ -147,12 +148,14 @@ def __setattr__(self, attr: str, val: Any) -> None:

self._task = _Stub()
else:
self._task = Task.init(
project_name=kwargs.get("project_name"),
task_name=kwargs.get("task_name"),
task_type=kwargs.get("task_type", Task.TaskTypes.training),
**experiment_kwargs,
)
self._task = Task.current_task()
if self._task is None:
self._task = Task.init(
project_name=kwargs.get("project_name"),
task_name=kwargs.get("task_name"),
task_type=kwargs.get("task_type", Task.TaskTypes.training),
**experiment_kwargs,
)

self.clearml_logger = self._task.get_logger()

Expand Down