#2313 fix bug in StateParamScheduler attach method#2316
Merged
vfdev-5 merged 4 commits intopytorch:masterfrom Nov 15, 2021
Merged
#2313 fix bug in StateParamScheduler attach method#2316vfdev-5 merged 4 commits intopytorch:masterfrom
vfdev-5 merged 4 commits intopytorch:masterfrom
Conversation
sdesrozis
reviewed
Nov 9, 2021
Contributor
|
@fco-dv Thank you, I left a comment. |
Contributor
KickItLikeShika
left a comment
KickItLikeShika
left a comment
There was a problem hiding this comment.
Thanks for the PR @fco-dv, left a comment!
vfdev-5
approved these changes
Nov 15, 2021
fco-dv
added a commit
to fco-dv/ignite
that referenced
this pull request
Nov 23, 2021
* pytorch#2313 fix bug in StateParamScheduler attach method * pytorch#2313 add assert if KeyError is raised * pytorch#2313 update test_multiple_scheduler_with_save_history Co-authored-by: vfdev <[email protected]>
Ishan-Kumar2
pushed a commit
to Ishan-Kumar2/ignite
that referenced
this pull request
Dec 26, 2021
* pytorch#2313 fix bug in StateParamScheduler attach method * pytorch#2313 add assert if KeyError is raised * pytorch#2313 update test_multiple_scheduler_with_save_history Co-authored-by: vfdev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2313
Description:
Fixing bug on StateParamScheduler attach method, add related test.
Check list: