Conversation
Collaborator
|
@ydcjeff thanks for the PR! I think it is ready to merge as it is. However, I understand now that we are still missing the correct way to trigger docker build. I think trigger it on
ignite/.github/workflows/docker-build.yml Lines 3 to 7 in ff3384b and ignite/.github/workflows/docker-publish.yml Lines 7 to 9 in ff3384b Probably, we also have to modify ignite/.github/workflows/docker-build.yml Lines 45 to 46 in ff3384b Let's also update MSDP to v0.3.13 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1874
Description:
Check list: