Skip to content

Add empty_like for NF4Tensor to support offloading #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janeyx99 merged 5 commits into from
Sep 16, 2024
Merged

Add empty_like for NF4Tensor to support offloading #881

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80b0325
Add overloads for NF4Tensor to support offloading
janeyx99 Sep 12, 2024
8fe70c6
Remove unneeded API, add test
janeyx99 Sep 16, 2024
3c3e090
lint
janeyx99 Sep 16, 2024
659fa8f
Fix up test and realize it was not doing what you thought
janeyx99 Sep 16, 2024
04a5b92
ruff
janeyx99 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/dtypes/test_nf4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
run_tests,
)
from torchao.dtypes.nf4tensor import (
NF4Tensor,
linear_nf4,
to_nf4,
_INNER_TENSOR_NAMES_FOR_SHARDING,
Expand Down Expand Up @@ -270,6 +271,14 @@ def test_chunk_size_equivalence(self, dtype: torch.dtype, shape, chunk_size):

torch.testing.assert_close(nf4_patched.quantized_data, nf4_base.quantized_data)

@parametrize("input_size", [(512 * 512,), (512, 512)])
def test_empty_like(self, input_size: Union[Tuple[int], int]):
nf4_tensor = to_nf4(torch.rand(input_size))
new_tensor = torch.empty_like(nf4_tensor, device=torch.device("cpu"))
Copy link
Contributor

@jerryzh168 jerryzh168 Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: to make sure device arg works, can you make sure the nf4_tensor is on gpu?

self.assertTrue(isinstance(new_tensor, NF4Tensor))
self.assertEqual(new_tensor.get_device(), -1) # that it's on CPU
self.assertEqual(new_tensor.size(), nf4_tensor.size())


class TestFSDPOps(TestCase):
@parametrize("input_size", [512 * 512, (512 * 512,), (512, 512)])
Expand Down
1 change: 1 addition & 0 deletions torchao/dtypes/nf4tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ def clone(func, *args, **kwargs):
@implements(
[
aten.detach.default,
aten.empty_like.default,
]
)
def nf4_detach(aten_op, args, kwargs=None):
Expand Down