Fold tbe/stats/ into tbe/monitoring/ for better organization#5591
Closed
q10 wants to merge 1 commit into
Closed
Conversation
Summary: Move `bench_params_reporter.py` from `tbe/stats/` into `tbe/monitoring/` to collocate all three TBE runtime monitoring hooks in one package. Delete the now-empty `tbe/stats/` subpackage. Like `TBEStatsReporter` and `TBEInputMultiplexer`, `TBEBenchmarkParamsReporter` is a passive forward() observer in the training operator. Grouping them together makes the package self-documenting and eliminates a confusing single-file subpackage. To preserve the lightweight `tbe:monitoring` target (only depends on torch), the reporter lives in a separate `tbe:bench_params_reporter` BUCK target with its heavy C++ and Manifold dependencies. The two targets share the `monitoring/` directory but are fully independent. Changes: - Move bench_params_reporter.py to tbe/monitoring/ - Delete tbe/stats/ directory (\_\_init\_\_.py and bench_params_reporter.py) - Split BUCK: tbe:monitoring (lightweight) + tbe:bench_params_reporter (heavy) - Remove old tbe:stats and tbe:dummy_stats_backend_bc targets - Update 2 internal consumers to import from new path No re-export shell needed \u2014 only 2 internal consumers, not externed in torch.package. Reviewed By: cthi Differential Revision: D99739698
Contributor
Contributor
|
This pull request has been merged in 141dc0d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move
bench_params_reporter.pyfromtbe/stats/intotbe/monitoring/to collocateall three TBE runtime monitoring hooks in one package. Delete the now-empty
tbe/stats/subpackage.
Like
TBEStatsReporterandTBEInputMultiplexer,TBEBenchmarkParamsReporteris apassive forward() observer in the training operator. Grouping them together makes the
package self-documenting and eliminates a confusing single-file subpackage.
To preserve the lightweight
tbe:monitoringtarget (only depends on torch), the reporterlives in a separate
tbe:bench_params_reporterBUCK target with its heavy C++ andManifold dependencies. The two targets share the
monitoring/directory but are fullyindependent.
Changes:
No re-export shell needed \u2014 only 2 internal consumers, not externed in torch.package.
Reviewed By: cthi
Differential Revision: D99739698