Remove AVX file from aarch64 compilation#5458
Closed
Nicoshev wants to merge 1 commit into
Closed
Conversation
Contributor
Summary: X-link: facebookresearch/FBGEMM#2430 We are removing QuantUtilsAvx2.cc from fbgemm SVE compilation. QuantUtilsAvx2.cc currently compiles for aarch64 using translation layers, which increase build times and can hide performance optimization opportunities. Reviewed By: YifanYuan3 Differential Revision: D95431713
Nicoshev
force-pushed
the
export-D95431713
branch
from
b47e540 to
53a5faa
Compare
Contributor
|
This pull request has been merged in 8d08cc1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We are removing QuantUtilsAvx2.cc from fbgemm SVE compilation.
QuantUtilsAvx2.cc currently compiles for aarch64 using translation layers, which increase build times and can hide performance optimization opportunities.
Reviewed By: YifanYuan3
Differential Revision: D95431713