Replace data_ptr with {const,mutable}_data_ptr (#5282)#5291
Closed
q10 wants to merge 1 commit into
Closed
Conversation
Contributor
Summary: Pull Request resolved: #5291 X-link: https://github.com/facebookresearch/FBGEMM/pull/2284 Most changes are to use const_data_ptr to avoid additional overheads. Pull Request resolved: #5282 Reviewed By: r-barnes Differential Revision: D90131661 Pulled By: q10
Contributor
jensenhwa
pushed a commit
to jensenhwa/FBGEMM
that referenced
this pull request
Mar 18, 2026
Summary: Pull Request resolved: pytorch#5291 X-link: https://github.com/facebookresearch/FBGEMM/pull/2284 Most changes are to use const_data_ptr to avoid additional overheads. Pull Request resolved: pytorch#5282 Reviewed By: r-barnes Differential Revision: D90131661 Pulled By: q10 fbshipit-source-id: 2cec29e83b615d2a0b8b6d4515661178e7833933
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2284
Most changes are to use const_data_ptr to avoid additional overheads.
Reviewed By: r-barnes
Differential Revision: D90131661
Pulled By: q10