Fix overflow in attention workspace calculation#4939
Closed
jwfromm wants to merge 1 commit into
Closed
Conversation
Summary: During workspace calculation some of the additions risked overflowing int32 and returning an invalid value. This diff makes sure that we're doing higher precision arithmetic in the workspace to prevent this issue. Reviewed By: q10 Differential Revision: D83370379
❌ Deploy Preview for pytorch-fbgemm-docs failed.
|
Contributor
Contributor
|
This pull request has been merged in dbc93d4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: During workspace calculation some of the additions risked overflowing int32 and returning an invalid value. This diff makes sure that we're doing higher precision arithmetic in the workspace to prevent this issue.
Reviewed By: q10
Differential Revision: D83370379