Fix loading weight with metaheader for eviction#4769
Closed
EddyLXJ wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80907245 |
EddyLXJ
added a commit
to EddyLXJ/FBGEMM-1
that referenced
this pull request
Aug 25, 2025
Summary: X-link: facebookresearch/FBGEMM#1791 There is a bug in init new block to update feature score metadata, we have to copy all value into block then update metadata. Differential Revision: D80907245
bfaffab to
4f391cf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80907245 |
4f391cf to
0ecabb4
Compare
EddyLXJ
added a commit
to EddyLXJ/FBGEMM-1
that referenced
this pull request
Aug 25, 2025
Summary: X-link: facebookresearch/FBGEMM#1791 There is a bug in init new block to update feature score metadata, we have to copy all value into block then update metadata. Reviewed By: emlin Differential Revision: D80907245
0ecabb4 to
11719dd
Compare
EddyLXJ
added a commit
to EddyLXJ/FBGEMM-1
that referenced
this pull request
Aug 25, 2025
Summary: X-link: facebookresearch/FBGEMM#1791 There is a bug in init new block to update feature score metadata, we have to copy all value into block then update metadata. Reviewed By: emlin Differential Revision: D80907245
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80907245 |
EddyLXJ
added a commit
to EddyLXJ/FBGEMM-1
that referenced
this pull request
Aug 25, 2025
Summary: Pull Request resolved: pytorch#4769 X-link: facebookresearch/FBGEMM#1791 There is a bug in init new block to update feature score metadata, we have to copy all value into block then update metadata. Reviewed By: emlin Differential Revision: D80907245
11719dd to
4d18598
Compare
Summary: Pull Request resolved: pytorch#4769 X-link: facebookresearch/FBGEMM#1791 There is a bug in init new block to update feature score metadata, we have to copy all value into block then update metadata. Reviewed By: emlin Differential Revision: D80907245
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80907245 |
4d18598 to
e6a255e
Compare
Contributor
|
This pull request has been merged in f771823. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: There is a bug in init new block to update feature score metadata, we have to copy all value into block then update metadata.
Differential Revision: D80907245