Skip AVX branches for EmbeddingSpMDM when in_type == BFLOAT16 && out_type == FLOAT (#4676)#4685
Closed
q10 wants to merge 1 commit into
Closed
Skip AVX branches for EmbeddingSpMDM when in_type == BFLOAT16 && out_type == FLOAT (#4676)#4685q10 wants to merge 1 commit into
q10 wants to merge 1 commit into
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80063522 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…type == FLOAT (#4685) Summary: Pull Request resolved: #4685 X-link: facebookresearch/FBGEMM#1712 As discussed in #4566, the AVX2 implementation is buggy. It's skipped and the computation falls through to AUTOVEC implementation. Pull Request resolved: #4676 Reviewed By: cthi Differential Revision: D80063522 Pulled By: q10
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80063522 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1712
As discussed in #4566, the AVX2 implementation is buggy. It's skipped and the computation falls through to AUTOVEC implementation.
Reviewed By: cthi
Differential Revision: D80063522
Pulled By: q10