fix partial rowwise adam optimizer offloading memory alignment#4645
Closed
emlin wants to merge 1 commit into
Closed
fix partial rowwise adam optimizer offloading memory alignment#4645emlin wants to merge 1 commit into
emlin wants to merge 1 commit into
Conversation
Summary: X-link: facebookresearch/FBGEMM#1680 This diff introduced one temporary memory and then copy the m1 state from lxu cache to this 16 byte aligned memory for vec4t to load, which can avoid strict alignment requirement placed on cached data. Reviewed By: q10 Differential Revision: D79589393
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79589393 |
Contributor
|
This pull request has been merged in 715ee60. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1680
This diff introduced one temporary memory and then copy the m1 state from lxu cache to this 16 byte aligned memory for vec4t to load, which can avoid strict alignment requirement placed on cached data.
Reviewed By: q10
Differential Revision: D79589393