Redo D78182966: Extend backend_return_whole_row to support multiple optimizer states#4620
Closed
q10 wants to merge 1 commit into
Closed
Redo D78182966: Extend backend_return_whole_row to support multiple optimizer states#4620q10 wants to merge 1 commit into
q10 wants to merge 1 commit into
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78879243 |
…ptimizer states Summary: X-link: facebookresearch/FBGEMM#1654 This diff is a redo of D78182966. There are 4 cases to handle when attempting to fetch the split optimizer states. All 4 cases have been already handled. With D77666892, we introduce a 5th case - the KV ZCH case, where `backend_return_whole_row` is `True`. This diff extends the work by cleaning up the code, handling the merge conflicts with diff D77666892, and expanding it to support returning multiple optimizer states. Reviewed By: sryap Differential Revision: D78879243
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78879243 |
Contributor
|
This pull request has been merged in e42a408. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is a redo of D78182966.
There are 4 cases to handle when attempting to fetch the split optimizer states. All 4 cases have been already handled.
With D77666892, we introduce a 5th case - the KV ZCH case, where
backend_return_whole_rowisTrue.This diff extends the work by cleaning up the code, handling the merge conflicts with diff D77666892, and expanding it to support returning multiple optimizer states.
Reviewed By: sryap
Differential Revision: D78879243